Enable copyright-check and update copyrights #4650

jbescos · 2020-12-02T13:38:09Z

Currently the build doesn't fail when copyright fails because we need to execute this one: glassfish-copyright:check

There are many dates to update.

Jersey-bot updates pom files version, but the date was not updated. When jersey-bot runs it should invoke 'glassfish-copyright:repair'
Many files were updated in this commit 'Move CDI integration tests to a common CDI-Integration module (Move CDI integration tests to a common CDI-Integration module #4280)' but the date was not updated.

senivam · 2020-12-02T14:25:08Z

actually I do not agree with automatic build failure (that is why it was copyright:copyright). Typical use case is when new Jersey release is published and all pom.xml files are modified and they are being modified with jersey-bot which belongs to Eclipse and has nothing to do with Oracle. Any other contribution from community also does not necessary shall update Oracle's copyright. Payara for instance has its own copyright.

Basically the whole community shall not bother with Oracle's copyright, except people from Oracle :)

jansupol · 2020-12-02T14:31:02Z

This is NOT Oracle copyright. This is Oracle and affiliates' copyright. If I understand it correctly, any contributor is understood as an affiliate.

Regarding the release, I believe it is possible to update the copyright year in poms by a sed swarm, is it not?

jansupol · 2020-12-02T14:48:31Z

connectors/jetty-connector/src/test/java/org/glassfish/jersey/jetty/connector/ProxyTest.java

@@ -1,4 +1,5 @@
 /*
+ * Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.


There seems to be something wrong. This file was not modified in 2020 and yet the copyright plugin requires a copyright change.

It is because the plugin removed the section, and this is considered as a new change.

Contributors:

Marcelo Rubim

There is also a new line added.

jbescos · 2020-12-02T14:52:51Z

...g-selectable/src/main/java/org/glassfish/jersey/examples/entityfiltering/selectable/App.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2014, 2019Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.


This seems wrong, I will fix it by 2014, 2020

senivam · 2020-12-02T16:32:12Z

This is NOT Oracle copyright. This is Oracle and affiliates' copyright. If I understand it correctly, any contributor is understood as an affiliate.

As I remember, this project was contributed to Eclipse, since then any contributor is understood as Eclipse's affiliate. That is why ECA sign is required for any IP contribution.

If it would be Helidon project, then yes, it belongs to Oracle, but this project belongs to Eclipse.

m0mus · 2020-12-03T11:31:44Z

Just want to confirm the copyright should be in this format:

Copyright (c) 2002, 2020 Oracle and/or its affiliates. All rights reserved.

where 2002 is the year when this file was originally created and 2020 the year of last change.
If the file is new it's just

Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.

senivam · 2020-12-03T11:45:44Z

OK, after all discussions I have to agree with build failure in Travis build due to copyright year changes.

jbescos · 2020-12-04T07:25:08Z

For some reason in Travis it fails in the first module, but there is no information about why it fails. Locally it is working.

I need to push some commits to print more information, but the problem is that Travis seems to be running nightly. It is going to take some time to find why is it failing in Travis.

senivam · 2020-12-04T11:07:32Z

media/json-jackson/src/main/resources/META-INF/NOTICE.markdown

@@ -1,4 +1,20 @@
-# Notice for Jersey Json Jackson module 
+#
+# Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.


this is kinda .md file (only with .markdown extension), shall be excluded from Copyright check.

Done, it is also added in the .markdown in the jersey/etc/config/copyright-exclude

senivam · 2020-12-04T11:14:26Z

pom.xml

                    <configuration>
                        <excludeFile>etc/config/copyright-exclude</excludeFile>
                        <!--svn|mercurial|git - defaults to svn-->
                        <scm>git</scm>
                        <!-- turn on/off debugging -->
-                        <debug>false</debug>
+                        <debug>true</debug>


why in debug mode?

I have added it temporarily to know why is it failing in Travis. Currently it fails but there is no information of the error.

for now build did not even started since the last change :) Travis seems to be really slow recently.
Regarding additional info - it might not show it because of reduced output in Travis. We had to reduce it due to Travis' limitations, otherwise all build threads would fail. May be you can temporary try to run it with full log output (just for copyright-check thread) and this will show what actually happened there?

ah, no, copyright already runs with full output, so may be -e key will help when build finally starts :)

I tried it yesterday with -e already but the stacktrace doesn't help, you can see it here:
https://travis-ci.org/github/eclipse-ee4j/jersey/jobs/747370995

Hopefully debug=true will help.

Locally there are no problems. I don't really understand why in Travis it works different.

the issue with no output on failures seems to be caused by this hard-coded logic inside the plugin:
https://github.com/eclipse-ee4j/glassfish-copyright-plugin/blob/94c7ba4c6d3151b57f92cf030f77661f1ff15d17/src/main/java/org/glassfish/copyright/CheckCopyrightMojo.java#L33
It's being always quiet in other words. And when you remove this hard-coded line (default is false), you can see why build fails. However fix requires new PR and then new plugin version shall be released...

senivam

current content looks good to me, however due to discovered issue with glassfish-copyright-plugin it's required to fix (or provide some workaround) for error output, and this will introduce some changes in the current PR (like plugin version update or something), so, it shall be merged only after reliable solution for error output inside glassfish-copyright-plugin is provided (and this PR is adjusted accordingly).

senivam · 2020-12-08T07:35:40Z

@jbescos could you please update plugin's version to 2.4? And it's required to disable quiet mode by external parameter -Dcopyright.quiet=false

jbescos · 2020-12-14T07:01:05Z

@senivam finally it is working in Travis

senivam

it looks like all passes OK, settings for copyright plugin and related build configuration are adjusted correctly, changes can be merged.

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>

jbescos · 2021-01-26T13:36:13Z

There are some issues with the rebase of my commits, because my commits belongs to 2020 and new files have been modified in 2021. The plugin is not dealing well with that.

jbescos force-pushed the copyright branch from 9e29fac to 2b5eaa1 Compare December 2, 2020 14:09

jbescos requested review from jansupol and senivam December 2, 2020 14:09

jansupol reviewed Dec 2, 2020

View reviewed changes

jbescos commented Dec 2, 2020

View reviewed changes

jbescos force-pushed the copyright branch from bb3a031 to fc17aad Compare December 3, 2020 08:14

senivam approved these changes Dec 3, 2020

View reviewed changes

jbescos force-pushed the copyright branch 2 times, most recently from cec2c9e to 77663d8 Compare December 4, 2020 07:20

senivam requested changes Dec 4, 2020

View reviewed changes

jbescos force-pushed the copyright branch 2 times, most recently from 155f57e to 4f65556 Compare December 7, 2020 07:37

senivam reviewed Dec 7, 2020

View reviewed changes

jbescos force-pushed the copyright branch 2 times, most recently from 912027f to 5de6d9f Compare December 10, 2020 08:04

senivam approved these changes Dec 14, 2020

View reviewed changes

jbescos force-pushed the copyright branch from 5de6d9f to 87edebc Compare January 4, 2021 06:51

jbescos force-pushed the copyright branch 2 times, most recently from 27df867 to bf7e7fa Compare January 14, 2021 11:40

jbescos force-pushed the copyright branch from bf7e7fa to 507f0b5 Compare January 26, 2021 12:35

Copyright fails the build

08ec0c7

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>

jbescos force-pushed the copyright branch from 14bbee9 to 08ec0c7 Compare January 26, 2021 13:13

jbescos closed this Jan 26, 2021

jbescos mentioned this pull request Jan 26, 2021

Copyright check #4701

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable copyright-check and update copyrights #4650

Enable copyright-check and update copyrights #4650

jbescos commented Dec 2, 2020

senivam commented Dec 2, 2020

jansupol commented Dec 2, 2020

jansupol Dec 2, 2020

jbescos Dec 2, 2020 •

edited

Loading

jbescos Dec 2, 2020 •

edited

Loading

senivam commented Dec 2, 2020

m0mus commented Dec 3, 2020

senivam commented Dec 3, 2020

jbescos commented Dec 4, 2020

senivam Dec 4, 2020

jbescos Dec 4, 2020

senivam Dec 4, 2020

jbescos Dec 4, 2020

senivam Dec 4, 2020

senivam Dec 4, 2020

jbescos Dec 4, 2020

senivam Dec 7, 2020

senivam left a comment

senivam commented Dec 8, 2020 •

edited

Loading

jbescos commented Dec 14, 2020

senivam left a comment

jbescos commented Jan 26, 2021

		@@ -1,4 +1,5 @@
		/*
		* Copyright (c) 2020 Oracle and/or its affiliates. All rights reserved.

Enable copyright-check and update copyrights #4650

Enable copyright-check and update copyrights #4650

Conversation

jbescos commented Dec 2, 2020

senivam commented Dec 2, 2020

jansupol commented Dec 2, 2020

Choose a reason for hiding this comment

jbescos Dec 2, 2020 • edited Loading

Choose a reason for hiding this comment

jbescos Dec 2, 2020 • edited Loading

Choose a reason for hiding this comment

senivam commented Dec 2, 2020

m0mus commented Dec 3, 2020

senivam commented Dec 3, 2020

jbescos commented Dec 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

senivam left a comment

Choose a reason for hiding this comment

senivam commented Dec 8, 2020 • edited Loading

jbescos commented Dec 14, 2020

senivam left a comment

Choose a reason for hiding this comment

jbescos commented Jan 26, 2021

jbescos Dec 2, 2020 •

edited

Loading

jbescos Dec 2, 2020 •

edited

Loading

senivam commented Dec 8, 2020 •

edited

Loading