Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optionals when empty #5194

Merged
merged 3 commits into from
Dec 1, 2022
Merged

Fix optionals when empty #5194

merged 3 commits into from
Dec 1, 2022

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Nov 14, 2022

There was one issue with optionals when the parameter was empty.

@jbescos jbescos force-pushed the optionalFix branch 2 times, most recently from 0ed2544 to 580771d Compare November 15, 2022 08:32
@jbescos
Fix optionals when empty
d6f2f38 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Merge branch 'master' of https://github.com/eclipse-ee4j/jersey into …
95f0c0a 
…optionalFix

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jansupol
Copy link
Contributor

It would be interesting to test @NotNull Integer nullable and @NotNull Optional<Integer> nullable. While the first should fail with bean validation, I'd say the second should not.

@jbescos
Review comments
84198e3 
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos
Copy link
Member Author

jbescos commented Nov 21, 2022

It would be interesting to test @NotNull Integer nullable and @NotNull Optional<Integer> nullable. While the first should fail with bean validation, I'd say the second should not.

Added in this commit: 84198e3

@senivam senivam merged commit fd07a38 into eclipse-ee4j:master Dec 1, 2022
@senivam senivam added this to the 2.38 milestone Dec 1, 2022
This was referenced Dec 22, 2022
Merged
Closed
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Open
Merged
Closed
Merged
Closed
Merged
Merged
Merged
@renovate renovate bot mentioned this pull request Feb 17, 2023
Closed
1 task
This was referenced Mar 16, 2023
Open
Open
Open
Open
Closed
Closed
Open
Open
@renovate renovate bot mentioned this pull request Mar 23, 2023
Closed
1 task
This was referenced May 11, 2023
Open
Open
This was referenced Jun 1, 2023
Merged
Closed
This was referenced Jun 4, 2023
Merged
Closed
This was referenced Jun 15, 2023
Merged
Merged
This was referenced Jul 6, 2023
Open
Open
This was referenced Aug 28, 2023
Merged
Merged
This was referenced Jan 16, 2024
Closed
Closed
@renovate renovate bot mentioned this pull request Mar 1, 2024
Merged
1 task
This was referenced Mar 18, 2024
Merged
Closed
This was referenced Apr 13, 2024
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@jansupol jansupol jansupol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.38
Development

Successfully merging this pull request may close these issues.
3 participants
@jbescos @jansupol @senivam