More release checks #5664
Merged
More release checks #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jansupol <jan.supol@oracle.com>
senivam
approved these changes
May 28, 2024
jbescos
reviewed
May 31, 2024
| final int minVersion; | ||
| if (jerseyVersion.startsWith("4")) { | ||
| minVersion = 17; | ||
| } else if (jerseyVersion.startsWith("3.1")) { |
There was a problem hiding this comment.
In case we create a new 3.2 version we will need to remember to update this or it will fall to version 8. Maybe it is preferable to use a regular expression, something like: ^3\.[1-9]+ (please test it because I am not good with regular expressions).
jbescos
approved these changes
May 31, 2024
1 task
1 task
This was referenced Jul 30, 2024
Closed
1 task
This was referenced Aug 2, 2024
1 task
1 task
This was referenced Sep 7, 2024
1 task
This was referenced Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.