Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NPE in micrometer when there is no response & 404 #5690

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Prevent NPE in micrometer when there is no response & 404 #5690

merged 2 commits into from
Jul 16, 2024

Conversation

jansupol
Copy link
Contributor

@jansupol jansupol commented Jul 3, 2024

No description provided.

@jansupol
Prevent NPE in micrometer when there is no response & 404
1e68502 
Signed-off-by: jansupol <jan.supol@oracle.com>
@jansupol jansupol linked an issue Jul 3, 2024 that may be closed by this pull request
NPE after switching to jersey-micrometer #5687
Closed
@zapodot
Copy link

zapodot commented Jul 4, 2024

👍🏼

@jansupol
Copy link
Contributor Author

jansupol commented Jul 4, 2024

I'd prefer to not squash these 2 commits

@jansupol jansupol mentioned this pull request Jul 4, 2024
Merged
@nioertel
Copy link

nioertel commented Jul 10, 2024 •
edited
Loading

👍
Would love to see this fix in a hopefully soon to be released 3.1.8.

@senivam senivam requested a review from jbescos July 16, 2024 07:18
@senivam senivam merged commit 80951a4 into eclipse-ee4j:2.x Jul 16, 2024
7 checks passed
@senivam senivam added this to the 2.44 milestone Jul 16, 2024
@nioertel
Copy link

@senivam, @jbescos I just saw that this PR was against 2.x only. Is there a standard mechanism for forward merging or do you need a separate PR for 3.1?

@nioertel
Copy link

This is actually a major issue because I am currently working on a quite big REST API that is designed in a way that 404 is considered a "good" response and since upgrade to Spring Boot 3.3.x lots of tests are failing.

Please let me know if I can somehow support so we can maybe get a 3.1.8 release including this fix before end of July.

@senivam
Copy link
Contributor

senivam commented Jul 17, 2024

@nioertel uptaking of changes/fixes is done in the order 2.x -> 3.0 -> 3.1 -> 4.0. At least (but might be more often) before a release of a particular version (3.0.x, 3.1.x,...) the previous branch is being merged into the one the release is done from. This ensures all fixes from the prior versions are included in a particular release.

@solrbot solrbot mentioned this pull request Jul 30, 2024
Closed
1 task
This was referenced Jul 30, 2024
Open
Merged
@renovate-bot renovate-bot mentioned this pull request Jul 30, 2024
Closed
1 task
This was referenced Jul 30, 2024
Merged
Open
Merged
Open
Closed
Open
Merged
Open
Merged
@github-actions github-actions bot mentioned this pull request Aug 2, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Aug 2, 2024
Open
1 task
This was referenced Aug 2, 2024
Open
Draft
Open
@solrbot solrbot mentioned this pull request Aug 3, 2024
Closed
1 task
@renovate renovate bot mentioned this pull request Aug 3, 2024
Open
1 task
This was referenced Sep 7, 2024
Merged
Open
@renovate renovate bot mentioned this pull request Sep 15, 2024
Open
1 task
This was referenced Sep 29, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senivam senivam senivam approved these changes

@jbescos jbescos jbescos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.44
Development

Successfully merging this pull request may close these issues.

NPE after switching to jersey-micrometer
5 participants
@jansupol @zapodot @nioertel @senivam @jbescos