Merge pull request #5178 from eclipse-ee4j/mojarra_issue_5140

Fix Mojarra issue 5140 html code inside ui:decorate breaks ui:param evaluation
eclipse-ee4j · Nov 17, 2022 · 8dee9ce · 8dee9ce
2 parents 87995e6 + 8edc4b5
commit 8dee9ce
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/impl/src/main/java/com/sun/faces/facelets/compiler/CompilationManager.java b/impl/src/main/java/com/sun/faces/facelets/compiler/CompilationManager.java
@@ -295,12 +295,10 @@ public void popTag() {
                 finishUnit();
             } else {
                 t.endTag();
-                if (t.isClosed()) {
-                    this.finishUnit();
-                }
                 return;
             }
-            unit = this.currentUnit();
+
+            unit = currentUnit();
         }
 
         if (unit instanceof TagUnit) {
@@ -328,9 +326,14 @@ public void pushNamespace(String prefix, String uri) {
         }
 
         boolean alreadyPresent = namespaceManager.getNamespace(prefix) != null;
+
+        if (alreadyPresent) {
+            return;
+        }
+
         namespaceManager.pushNamespace(prefix, uri);
         NamespaceUnit unit;
-        if (currentUnit() instanceof NamespaceUnit && !alreadyPresent) {
+        if (currentUnit() instanceof NamespaceUnit) {
             unit = (NamespaceUnit) currentUnit();
         } else {
             unit = new NamespaceUnit(tagLibrary);