Bug 4262 - don't restore rowIndex in UIData#invokeOnComponent, if it … #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…was not modified setRowIndex is called in finally, even if the rowIndex was not modified by invokeOnComponent. This leads to unexpected method calls. This commit reduces the scope of the try catch finally. Signed-off-by: Frank Caputo <frank@frankcaputo.de>
arjantijms
approved these changes
Nov 3, 2018
|
@fcaputo Thanks Franks! lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…was not modified
setRowIndex is called in finally, even if the rowIndex was not modified
by invokeOnComponent. This leads to unexpected method calls. This commit
reduces the scope of the try catch finally.