Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem introduced in JAVASERVERFACES_SPEC_PUBLIC-1329, also cons… #4643

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

soul2zimate
Copy link
Contributor

@soul2zimate soul2zimate commented Oct 11, 2019

…ider Submitted value "" when EMPTY_STRING_AS_NULL_PARAM_NAME is enabled.

2.3 branch PR: #4644
Fix #4550
As commit javaserverfaces/mojarra@4c74d1f#diff-d9a3cf30923f6318a8387c91e42aa0d4R295-R302 changed null to "" when EmptyStringNull is considered.
It also needs this same change in UIInput

@soul2zimate
Copy link
Contributor Author

@arjantijms Could you review this please ?

…ider Submitted value "" when EMPTY_STRING_AS_NULL_PARAM_NAME is enabled.

Signed-off-by: Chao Wang <chaowan@redhat.com>
@soul2zimate
Copy link
Contributor Author

@arjantijms Could you review this please ?

@bmaxwell
Copy link

bmaxwell commented Jan 7, 2020

@bshannon / @arjantijms / @edburns - anyone who could review this one that has been open for a couple of months?

@bshannon
Copy link

bshannon commented Jan 8, 2020

@bshannon / @arjantijms / @edburns - anyone who could review this one that has been open for a couple of months?

I don't know the code so I can't help, but I added a few other reviewers who should be able to help.

@bmaxwell
Copy link

@arjantijms / @edburns / @mnriem anyone who can review this fix?

@fjuma
Copy link

fjuma commented Feb 10, 2020

@arjantijms Any chance you could take a quick look at this one? We have a JBoss EAP customer running into this issue.

@juneau001 juneau001 self-assigned this Feb 17, 2020
@arjantijms
Copy link
Contributor

Sorry for the crazy long time to look into this. The bandwidth for this project is very limited it seems. In the October/November timeframe I've personally needed to get up to date with new customer's projects, and in January/February I spend the little free time I have on the security specs. Not sure about the other committers.

This PR is however to master, which was the early attempt to get a 3.0 going before all the jakarta requirements came in. It should go to the 2.3 branch but that PR has been closed for some reason.

I'll merge it in here anyway, and will cherry pick it to 2.3 then.

@arjantijms arjantijms merged commit 09acb6e into eclipse-ee4j:master Feb 25, 2020
@fjuma
Copy link

fjuma commented Feb 25, 2020

Thanks very much, @arjantijms!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ViewParam field is Null after click primefaces commandbutton (Mojarra 2.2 dont)
6 participants