MockServletContext - clean-up #5128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Emkas
commented
Jun 24, 2022
Emkas
commented
- Add @OverRide
- Remove unused functions/methods
- Add raw types where they can be used
Emkas
force-pushed
the
mock-servler-context-clean-up
branch
from
9a96df8
to
c75e3d0
Compare
BalusC
reviewed
Jun 24, 2022
| public String getInitParameter(String name) { | ||
| return ((String) parameters.get(name)); | ||
| return (parameters.get(name)); |
There was a problem hiding this comment.
While you're at it, unnecessary parenthesis should also be removed over all place.
* Add @OverRide * Remove unused functions/methods * Add raw types where they can be used Signed-off-by: Emil Sierżęga <emilsierzega@gmail.com>
Emkas
force-pushed
the
mock-servler-context-clean-up
branch
from
c75e3d0
to
272b06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.