Maven JS compressor + Faces.js optimization + partial submit #5141
Conversation
Maven - Removed yuicompressor (dead project with no support for ES6+ js) + Added Google Closure maven plugin for minification Faces JS + tested and minified with ECMASCRIPT5_STRICT profile of Google Closure + use strict + const and let instead of var - Removed IE-5-6-7-8-9-10 support - Removed IE 5-6-7 hacks and memory hacks - Removed FrameTransport - Removed / Commented out unused and very old functions and code + FormData for File upload + Many minor optimizations + for..of instead of for with index + Partial Submit ported and adapted from OmniFaces + 10 kB Minified and Gzipped Signed-off-by: pizzi80 <paolo@given2.com>
impl/src/main/resources/META-INF/resources/jakarta.faces/faces-uncompressed.js
Show resolved
Hide resolved
| * @ignore | ||
| */ | ||
| // switch to an async IIFE? | ||
| // TODO: async requires Safari 10... it was released on 2017... it's ok? |
There was a problem hiding this comment.
I'd prefer to wait until we can convert to typescript.
There was a problem hiding this comment.
I've spent some time to investigate the overall deprecation of old software...
Actually Safari 10 - 11 - 12 - 13 - 14 are not supported anymore by Apple
Even a 10 years old Macbook can upgrade to
"Big Sur", which include Safari version 15.5
https://discussions.apple.com/thread/253968805
IOS 11 with Safari 11 is availble since September 2017 ( 5 years ago )
and it's available for upgrade even of iPhone 5S (which is a 2013 phone)
IE11 is official in EOL from Microsoft
https://docs.microsoft.com/en-us/lifecycle/announcements/internet-explorer-11-end-of-support
So it is more than safe to updagrade to full ES6 support with async/await and Promise
Even more If you think that at the moment:
- the are no Official Application Servers supporting Jakarta EE 10
- there will be no Official Application Servers supporting Jakarta EE 10.1 before March 2023
(when Faces 4.1 will probably be released)
A side note on TypeScript
ES2022 is around the corner and is on par with TypeScript
https://dev.to/jasmin/whats-new-in-es2022-1de6
Obviously anyone is free do whatever they want with open source code but to me
rewrite all that code to TypeScript in 2023 is only a waste of (precious) time which
could spent to improve Java classes to perform better and cleaner and resolve bugs
my 2 cents
|
is there a proper way to push other commits to faces.js to this PR |
|
Merged. This will end up in next minor version 4.1. |
in 4.0.1-SNAPSHOT there is a bug
#5140
so I had to create a separate branch from 4.0.0 official release in my fork and commit/push
Maven
Faces JS
Faces JS - Partial Submit
Form partial submit jakartaee/faces#1696
#5045
#5040
jakartaee/faces#1598