Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes of warnings in tests #5149

Merged
merged 5 commits into from
Jul 27, 2022

Conversation

Emkas
Copy link
Contributor

@Emkas Emkas commented Jun 30, 2022

  • Fixed warnings in mocks - collective change for all warnings without changes in public interfaces
  • Fixed warnings in component tests - as above
  • HtmlResponseWriterTest: close writer - I know those are tests, but still, warnings easy to fix. I think this way is better than try-with-resources because any exception will break tests (and this is good)
  • Remove unused code
  • Remove empty UIComponent test overrides - they don't do anything. Tests are run anyway, because of the base class. This looks like generated code waiting to be filled.

@Emkas
Copy link
Contributor Author

Emkas commented Jul 27, 2022

ping :-)

Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping and the pr ;)

@arjantijms arjantijms added this to the 4.0.1 milestone Jul 27, 2022
@arjantijms arjantijms added the 4.0 label Jul 27, 2022
@arjantijms arjantijms merged commit 19fef96 into eclipse-ee4j:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants