Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FacesMessage optimizations #5260

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Conversation

pizzi80
Copy link
Contributor

@pizzi80 pizzi80 commented Jun 21, 2023

Signed-off-by: pizzi80 <paolo@given2.com>
@BalusC
Copy link
Contributor

BalusC commented Jun 24, 2023

This is a public API change. This needs a ticket in https://github.com/jakartaee/faces/issues

And this appears to be included in #5249

Signed-off-by: pizzi80 <paolo@given2.com>
@pizzi80
Copy link
Contributor Author

pizzi80 commented Jun 25, 2023

ok, reverted the breaking api changes

diff with #5249: I've inlined the static Map creation with a little lambda

@pizzi80 pizzi80 changed the title FacesMessage#VALUES / VALUES_MAP generic FacesMessage optimizations Jun 25, 2023
@arjantijms arjantijms added the 5.0 label Jul 6, 2023
@BalusC BalusC merged commit 28876a9 into eclipse-ee4j:master Jul 9, 2023
@pizzi80 pizzi80 deleted the 4.1.0_faces_message branch July 12, 2023 13:39
@BalusC BalusC added 4.1 and removed 5.0 labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants