5.0 Faces Standard Converters with Generics #5306
Conversation
+ Basic Converters use Generics + Enum Converter is now stateless Signed-off-by: pizzi80 <paolo@given2.com>
Signed-off-by: pizzi80 <paolo@given2.com>
…nverters_generics # Conflicts: # impl/src/main/java/com/sun/faces/util/Util.java # impl/src/main/java/jakarta/faces/convert/MessageFactory.java
pizzi80
changed the title
Signed-off-by: pizzi80 <paolo@given2.com>
|
@pizzi80 What is the status of this PR? |
|
The task was finalized on June 22 with the commit 6590ff1. However, due to numerous merged pull requests in the interim, This was necessitated by the decision of the Faces API community to defer the usage of Generics to Faces 5+ |
|
@pizzi80 So this PR can be closed out? |
|
If the master is now the version 5.0, |
|
@BalusC @arjantijms What do you think? |
impl/src/main/java/jakarta/faces/convert/BigDecimalConverter.java
Outdated
Show resolved
Hide resolved
|
@BalusC Thanks for taking the time to review my code .... I'll fix everything the next week |
+ Util.notNullArgs fixed typo + Faces Standard Converters with Generics + Faces Standard Converters uses Util.trimToNull and RIConstants.NO_VALUE Signed-off-by: pizzi80 <paolo@given2.com>
|
During this work I've found that inside the generic there are some ugly hacks for Java 1.4 and Java 7 that use reflection Jsf 2.3 is Java 8+, right? Can I remove the hacks on a separate PR? |
|
API has been split from Mojarra project into Faces project. Current PR is superseded by jakartaee/faces#1942 |
jakartaee/faces#1822