Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composite component can't find reparented child when it's in turn in another NamingContainer within the composite #5315

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Sep 9, 2023

#5214

E.g.

<cc:implementation>
  <h:form> <!-- or h:dataTable -->
    <cc:insertChildren>

caused the composite to recreate all children for cc:insertChildren brand new during render response of postback instead of reusing the ones already created during restore view.

another NamingContainer within the composite such as h:form or
h:dataTable; upon code analysis I found a line which seemed completely
unnecessary so I have removed it and it works again for me.
#5214
@BalusC BalusC changed the base branch from master to 4.0 September 9, 2023 16:00
@BalusC BalusC added the 4.0 label Sep 9, 2023
@BalusC BalusC added this to the 4.0.5 milestone Sep 9, 2023
@BalusC
Copy link
Contributor Author

BalusC commented Sep 9, 2023

I want to run TCK on this before merge.

@BalusC
Copy link
Contributor Author

BalusC commented Sep 9, 2023

TCK passed.

@BalusC BalusC merged commit cdea232 into 4.0 Sep 16, 2023
2 checks passed
@BalusC BalusC deleted the mojarra_issue_5214 branch September 16, 2023 13:12
BalusC added a commit that referenced this pull request Sep 16, 2023
BalusC added a commit that referenced this pull request Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants