Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move back weld reinit from ConfigureListener into FacesInitializer #5324

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Move back weld reinit from ConfigureListener into FacesInitializer #5324

merged 1 commit into from
Oct 7, 2023

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Sep 30, 2023

@mnriem
Copy link
Contributor

mnriem commented Oct 2, 2023

LGTM

@mnriem
Copy link
Contributor

mnriem commented Oct 6, 2023

@BalusC Can you please file an issue so we can tie all the ports (4.0, 4.1 and 5.0) to the issue?

@arjantijms
Copy link
Contributor

Lgtm, though I really wish we could somehow persuade the two CDI spec leads that Faces needs a universal solution for this in the CDI spec.

@melloware
Copy link
Contributor

@arjantijms if there is a CDI ticket open somewhere about this issue I am happy to go upvote it and have my friends upvote as well 😄

@BalusC
Copy link
Contributor Author

BalusC commented Oct 7, 2023

@BalusC Can you please file an issue so we can tie all the ports (4.0, 4.1 and 5.0) to the issue?

issue is already linked in 1st comment

@BalusC BalusC merged commit c2034cc into 4.0 Oct 7, 2023
2 checks passed
@BalusC BalusC deleted the mojarra_issue_5321_fix_failing_weld_reinitialization branch October 7, 2023 21:41
@BalusC BalusC mentioned this pull request Oct 7, 2023
Closed
@arjantijms arjantijms added the 4.0 label Nov 13, 2023
@arjantijms arjantijms added this to the 4.0.5 milestone Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnriem mnriem mnriem approved these changes

@arjantijms arjantijms Awaiting requested review from arjantijms

Assignees
No one assigned
Labels
4.0
Projects
None yet
Milestone
4.0.5
Development

Successfully merging this pull request may close these issues.
4 participants
@BalusC @mnriem @arjantijms @melloware