Merge ActionSource2 back into ActionSource and deprecate ActionSource2 related classes #5326
Conversation
| */ | ||
| @Deprecated(since = "4.1", forRemoval = true) |
There was a problem hiding this comment.
I doubt a 4.1 release will be done. Can you retarget it for 5.0?
There was a problem hiding this comment.
Sure but 4.1 branch still exist. Will do when 4.1 will be officially skipped and merged into 5.0 because it's easier to find&replace 4.1 / 4_1 by 5.0 / 5_0 in one go. The 4.1 branch has in its current form already a good couple of these.
There was a problem hiding this comment.
@BalusC Can you make sure you also file an implementation issue for this as well so we can tie the 2 PRs you will need. One targeting the 4.1 branch (this PR) 2. Another targeting the 5.0 branch? And link the implementation issue back to the spec issue? And set the 4.1 and 5.0 label on the implementation issue. Thanks!
|
ok but not sure I understand why .. github is capable of linking to issue in another repo as you can see in all previous tickets/prs/merges. |
BalusC
deleted the
faces_issue_1832_merge_ActionSource2_back_into_ActionSource
branch
Ease of generating release notes and later on ease of finding for the issue in which branches it was fixed by having a common ancestor. Similary API issues do not show up as release notes issues in Mojarra. |
#5327