Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Do not override application-specified "com.sun.faces.enableDistributable" value #5363

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

sudeshnas93
Copy link

@sudeshnas93 sudeshnas93 commented Nov 22, 2023

Mojarra defines a number of initialization parameters. While "com.sun.faces.enableDistributable" is one of them, Mojarra automatically overrides any existing setting provided by the application.
If a web application wanted explicitly disable this for a distributable web application, it would normally add a servlet context parameter within web.xml.
e.g.

<web-app>
  <distributable/>
  <context-param>
    <param-name>com.sun.faces.enableDistributable</param-name>
    <param-value>false</param-value>
  </context-param>
</web-app>

However, the ConfigureListener auto-enables the com.sun.faces.enableDistributable configuration property whenever it see that the tag in web.xml, overriding any custom setting.
I would expect Mojarra to respect the setting defined by the application, and only provide a default value if no value was specified.

Copy link
Contributor

@soul2zimate soul2zimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require the same deletion as same as #5347 ?

@BalusC
Copy link
Contributor

BalusC commented Nov 25, 2023

Does this require the same deletion as same as #5347 ?

Indeed. It should be the exact same change.

@sudeshnas93
Copy link
Author

Code changes have been made accordingly. Please review.

@mnriem
Copy link
Contributor

mnriem commented Nov 30, 2023

@sudeshnas93 Please make sure you use the same email as your Eclipse account so the ECA check passes

@sudeshnas93
Copy link
Author

I have used the same email address as that of Eclipse account and updated the ECA. Can this test be rerun again?
Thanks.

@mnriem mnriem added the 2.3 label Dec 5, 2023
@lvydra
Copy link

lvydra commented Dec 11, 2023

Hi @BalusC, could you please review the changes?

@BalusC BalusC merged commit adf0de3 into eclipse-ee4j:2.3 Dec 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants