Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@jakarta.faces.annotation.View#value must be @Nonbinding #5368

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Nov 26, 2023

@BalusC BalusC added this to the 4.1.0 milestone Nov 26, 2023
@BalusC BalusC merged commit 4228058 into 4.1 Nov 26, 2023
3 checks passed
@BalusC BalusC deleted the mojarra_issue_1865 branch November 26, 2023 18:41
@volosied
Copy link
Contributor

This causes some regressions in 5.0 / 4.1:

WELD-001318: Cannot resolve an ambiguous dependency between: - Managed Bean [class com.example.HelloFacelet2] with qualifiers [@Any @view], - Managed Bean [class com.example.HelloFacelet] with qualifiers [@Any @view]

I applied a similar change to MyFaces and found the same problem. I think View.Literal.of(someURI) during the bean lookup doesn't work now because the annotation is not considered anymore?

@BalusC
Copy link
Contributor Author

BalusC commented Nov 30, 2023

Right. There's the why. I'll have to revert this for now.

@BalusC
Copy link
Contributor Author

BalusC commented Nov 30, 2023

Reverted: 12ca56e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants