Consider ClosedChannelException as well when checking for connection abort #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnriem
approved these changes
Feb 15, 2024
|
Mojarra doesn't anymore have IT env (everything has been moved to Faces/TCK) and current UT env is super outdated with JUnit4/Easymock/Powermock, should become JUnit5/Mockito. |
melloware
approved these changes
Feb 17, 2024
BalusC
deleted the
mojarra_issue_5391_consider_ClosedChannelException_as_well_when_checking_for_connection_abort
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5391