Fix #5511: don't anymore rely on CodeSource#getLocation() #5519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obtain the URL of the resource itself via its own class loader
melloware
approved these changes
Oct 19, 2024
mnriem
requested changes
Oct 20, 2024
| if (annotatedSet != null) { | ||
| for (Class<?> clazz : annotatedSet) { | ||
| if (sourceURIString.contains(clazz.getProtectionDomain().getCodeSource().getLocation().toString())) { | ||
| String jarURIString = CURRENT_RESOURCE_IN_JAR_PATTERN.split(clazz.getResource(".").toString(), 2)[0]; |
There was a problem hiding this comment.
Not seeing a test here that validates this change over?
There was a problem hiding this comment.
Added integration test: 1ff6714
work in Tomcat and WildFly); so resorted to full class name
mnriem
approved these changes
Oct 25, 2024
BalusC
deleted the
mojarra_issue_5511_fix_deployment_fail_on_Tomcat_11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5511: don't anymore rely on CodeSource#getLocation(), instead obtain the URL of the resource itself via its own class loader