Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isErrorPage() check in RestoreViewPhase fails when thrown exception has a null message #5529

Open
wants to merge 1 commit into
base: 4.0
Choose a base branch
from

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Nov 16, 2024

@BalusC
Copy link
Contributor Author

BalusC commented Nov 16, 2024

Note: RequestMap#containsKey() doesn't work for 2 reasons:

  1. Tomcat doesn't set request attribute at all, even not with a null value. Neither Servlet nor Faces spec are sufficiently explicit to blame Tomcat on this.
  2. Mojarra's RequestMap impl doesn't check for attribute name but for attribute value (and this bug is apparently present in many other scope Map implementations -- this needs to be addressed via separate issue [Scope]Map#containsKey() doesn't check if key is present but only if value is non-null #5530

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any tests that validate all the (new) code paths?

@BalusC
Copy link
Contributor Author

BalusC commented Nov 23, 2024

Nope not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants