Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove top-level files from zip bundle #1556

Closed
pzygielo opened this issue Aug 11, 2022 · 0 comments · Fixed by #1557
Closed

Remove top-level files from zip bundle #1556

pzygielo opened this issue Aug 11, 2022 · 0 comments · Fixed by #1557

Comments

@pzygielo
Copy link
Contributor

I believe this top-level license file is actually the license file from OpenMQ. The way OpenMQ is included in the build is essentially by unpacking mq-dist.zip into the Payara install. Previously the license file for OpenMQ was under mq/legal and it has now been moved to be in the top-level of the zip (as in it's above mq). Under the same logic, I think the NOTICE.md file is also coming from OpenMQ.

It's very possible for them to come from OpenMQ indeed.

I suggest to adjust this here as well.

LICENSE.md is there (in top-level directory) - since 5.1.3 (first release after donation to EF), and was not there before (5.1.2-b01).
It's exactly the same file:

$ diff -s ./LICENSE.md ./mq/legal/LICENSE.txt
Files ./LICENSE.md and ./mq/legal/LICENSE.txt are identical

I believe NOTICE.md can land in mq/legal too, then top-level directory would contain mq only and all files would be in installation dir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant