Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong License in the Zip Distribution / FISH-6477 #5882

Closed
jansupol opened this issue Aug 8, 2022 · 6 comments
Closed

Wrong License in the Zip Distribution / FISH-6477 #5882

jansupol opened this issue Aug 8, 2022 · 6 comments
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect

Comments

@jansupol
Copy link

jansupol commented Aug 8, 2022

https://search.maven.org/artifact/fish.payara.distributions/payara/5.2022.2/zip binary distribution contains an EPLv2 license, unlike the CDDL + GPLv2+CPE license in the sources.

@jansupol jansupol added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification Type: Bug Label issue as a bug defect labels Aug 8, 2022
@JamesHillyard
Copy link
Member

Hi @jansupol,

Are you referring to the EPLv2 license which was added in this PR #3779 for the JakartaEE 8 components?

Thanks,
James

@JamesHillyard JamesHillyard self-assigned this Aug 8, 2022
@JamesHillyard JamesHillyard added Status: Pending Waiting on the issue requester to give more details or share a reproducer and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Aug 8, 2022
@jansupol
Copy link
Author

jansupol commented Aug 8, 2022

Possibly. It is the only LICENSE.md file in the zip, with no mention of EE8 relation. Feel free to close this issue if you think the license there is correct.

@JamesHillyard
Copy link
Member

Hi @jansupol,

Thank for you clarifying, I will raise this internally to verify the licences in our sources and binary distributions are correctly listed, and I will provide you with an update after we have verified this.

Best Regards,
James

@JamesHillyard JamesHillyard added Status: Open Issue has been triaged by the front-line engineers and is being worked on verification and removed Status: Pending Waiting on the issue requester to give more details or share a reproducer labels Aug 8, 2022
@Pandrex247
Copy link
Member

The actual license for Payara is under payara5/glassfish/legal.

I believe this top-level license file is actually the license file from OpenMQ.
The way OpenMQ is included in the build is essentially by unpacking mq-dist.zip into the Payara install. Previously the license file for OpenMQ was under mq/legal and it has now been moved to be in the top-level of the zip (as in it's above mq). Under the same logic, I think the NOTICE.md file is also coming from OpenMQ.

So yes we probably need to look at adjusting the bundling of OpenMQ within the build.

@JamesHillyard JamesHillyard added Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev and removed Status: Open Issue has been triaged by the front-line engineers and is being worked on verification labels Aug 11, 2022
@JamesHillyard JamesHillyard changed the title Wrong License in the zip distribution Wrong License in the Zip Distribution / FISH-6477 Aug 11, 2022
@JamesHillyard
Copy link
Member

Hi @jansupol,

Thank you for raising this issue, good spot! It is being tracked under the internal ID FISH-6477 and this will be investigated and fixed by the development team shortly.

Thanks,
James

@JamesHillyard
Copy link
Member

Hi @jansupol,

With thanks to @pzygielo who submitted a contribution to fix this, this issue has been resolved in Payara 6.2022.1.Alpha4 and will be fixed in the upcoming Payara 5.2022.4 release.

Thank you again for raising this issue.

Best Regards,
James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Bug Label issue as a bug defect
Projects
None yet
Development

No branches or pull requests

3 participants