Class StompFrameMessage does not know which protocol version is used on the connection #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
michaelJustin
commented
Jul 23, 2022
•
michaelJustin
commented
- Class StompFrameMessage does not know which protocol version is used on the connection #1524
…used on the connection
pzygielo
changed the title
pzygielo
requested changes
Jul 25, 2022
| @@ -22,4 +22,8 @@ | |||
| public interface StompFrameMessageFactory { | |||
|
|
|||
| StompFrameMessage newStompFrameMessage(StompFrameMessage.Command cmd, LoggerWrapper logger); | |||
|
|
|||
| void setVersion(String version); | |||
There was a problem hiding this comment.
It doesn't feel right place for version. Factory does not use this, and only serves as transport for it. I'd need (more) time to investigate other possibilities (or less time to review other solution).
There was a problem hiding this comment.
Yes, I see. The StompProtocolHandler already has the version private field, so this only needs to be exposed (using a getter). I will create a new PR. If I have done the fix for #1534, I will include it in the same PR.
|
I have created a new pull request (#1545) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.