Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Define standard property for handling duplicated keys #34

Merged
merged 6 commits into from
Dec 8, 2021

Conversation

jbescos
Copy link
Member

@jbescos jbescos commented Sep 29, 2021

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@jbescos jbescos marked this pull request as ready for review October 15, 2021 12:54
Copy link
Member

@lukasj lukasj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to refactor JsonObjectBuilder constructor to use this(...) instead of copy-pasting field initialization

@@ -20,6 +20,9 @@
/**
* Configuration property to reject duplicate keys. The value of the property could be
* be anything.

* Deprecated in favor of {@link jakarta.json.JsonConfig#IGNORE_NULL}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use @deprecated tag

jbescos and others added 5 commits October 19, 2021 07:02
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
…sue294

Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
@lukasj lukasj merged commit d35815c into eclipse-ee4j:master Dec 8, 2021
@lukasj lukasj linked an issue Dec 9, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[api] Define standard property for handling duplicated keys
2 participants