Update versions in poms and automatic module #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
jGauravGupta
approved these changes
Aug 27, 2020
ggam
reviewed
Aug 27, 2020
spi/bean-decorator/weld/pom.xml
Outdated
| @@ -77,7 +77,7 @@ | |||
| <archive> | |||
| <manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile> | |||
| <manifestEntries> | |||
| <Automatic-Module-Name>org.glassfish.soteria.bean.decorator.weld</Automatic-Module-Name> | |||
| <Automatic-Module-Name>org.glassfish.soteria.spi.bean.decorator</Automatic-Module-Name> | |||
There was a problem hiding this comment.
For consistency, we should rename the artifactId at the same time to match the new module name.
There was a problem hiding this comment.
@ggam after updating and testing the SPI, it appeared some more work was needed to get the tests running and the SPI with GF 6. I though we tested it before, but clearly we didn't, as some important exports are missing from the Weld OSGi bundle, so we can't use these. I worked around needing those exports.
Can you take a look again? Thx!
Updated tests since they didn't work anymore, and updated Weld SPI which didn't work on GF 6 anymore. Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
keilw
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: arjantijms arjan.tijms@gmail.com