Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage for jacoco. #278

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Add code coverage for jacoco. #278

merged 1 commit into from
Feb 11, 2025

Conversation

vhemery
Copy link
Contributor

@vhemery vhemery commented Jan 9, 2025

Report coverage correctly on verify phase with all test dependencies.

Does not implement the PR check suggested in eneufeld's comment

Fixes #266

@vhemery vhemery requested review from eneufeld and ndoschek January 9, 2025 11:31
@vhemery
Copy link
Contributor Author

vhemery commented Jan 9, 2025

Needs rebase after #280

Signed-off-by: Vincent Hémery <vincent.hemery@bonitasoft.com>
Copy link
Contributor

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vhemery for resolving this issue! Code coverage is now computed again as expected 🎉

@ndoschek ndoschek merged commit db7a399 into master Feb 11, 2025
8 checks passed
@ndoschek ndoschek deleted the issues/266 branch February 11, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JaCoCo code coverage report is not computed correctly
2 participants