Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest GLSP version due to API breaks #47

Closed
ndoschek opened this issue Jan 30, 2023 · 0 comments · Fixed by #50
Closed

Update to latest GLSP version due to API breaks #47

ndoschek opened this issue Jan 30, 2023 · 0 comments · Fixed by #50
Assignees
@ndoschek
Labels
enhancement New feature or request glsp modelserver EMF.cloud Model Server GLSP Integration

Comments

@ndoschek
Copy link
Contributor

Refactoring of OperationHandler type hierarchy API, see also eclipse-glsp/glsp-server#187
@ndoschek ndoschek added enhancement New feature or request glsp modelserver EMF.cloud Model Server GLSP Integration labels Jan 30, 2023
@ndoschek ndoschek self-assigned this Feb 2, 2023
ndoschek added a commit that referenced this issue Feb 15, 2023
@ndoschek
#47 Update to latest GLSP version due to API breaks
fbd589d 
- Refactoring of OperationHandler type hierarchy API, see also eclipse-glsp/glsp-server#187
  - Stay with executeOperation method as we manage command stack via Model Server
  - Merge interfaces and abstract operation handler classes
- Update GLSP and Model Server dependencies

Part of #47
@ndoschek ndoschek mentioned this issue Feb 15, 2023
Merged
ndoschek added a commit that referenced this issue Feb 15, 2023
@ndoschek
#47 #48 Update to latest GLSP version due to API breaks and fix unsub…
4e48d4b 
…scribing (#49)

* #48 Fix unsubscription on closing/reloading application

Until now unsubscribe was only triggered if a diagram editor was closed but not on application close/refresh.

Fixes #48

* #47 Update to latest GLSP version due to API breaks

- Refactoring of OperationHandler type hierarchy API, see also eclipse-glsp/glsp-server#187
  - Stay with executeOperation method as we manage command stack via Model Server
  - Merge interfaces and abstract operation handler classes
- Update GLSP and Model Server dependencies

Part of #47

* #43 Follow-up: Update maven settings and Jenkinsbuild

- Remove maven config and only use custom maven settings if necessary (i.e. Jenkinsbuild)
- Remove maven config and settings from project template
- Update Jenkinsbuild (do not build project-template with base framework as we have a separate build job for this)
ndoschek added a commit that referenced this issue Feb 15, 2023
@ndoschek
#47 Update project-template to latest versions
1cf0b4e 
- Update to latest GLSP and emfcloud versions
  - Adapt to API breaks due to latest GLSP version
- Update test workspace
  - Remove workspace settings (do not force disable of auto-save in workspace)
  - Restructure example model files
- Introduce tree label provider for .tasklist files
- Update VSCode workspace (include server folders separately to access launch configs and tasks)

Resolves #47
ndoschek added a commit that referenced this issue Feb 15, 2023
@ndoschek
#47 Update project-template to latest versions
8985e8d 
- Update to latest GLSP and emfcloud versions
  - Adapt to API breaks due to latest GLSP version
- Update test workspace
  - Remove workspace settings (do not force disable of auto-save in workspace)
  - Restructure example model files
- Introduce tree label provider for .tasklist files
- Update VSCode workspace (include server folders separately to access launch configs and tasks)
- Update build
  - Update outdated Jenkinsfile
  - Add checkstyle to m2 build and project-template builds

Resolves #47
@ndoschek ndoschek mentioned this issue Feb 15, 2023
Merged
ndoschek added a commit that referenced this issue Feb 16, 2023
@ndoschek
#47 Update project-template to latest versions (#50)
956c020 
- Update to latest GLSP and emfcloud versions
  - Adapt to API breaks due to latest GLSP version
- Update test workspace
  - Remove workspace settings (do not force disable of auto-save in workspace)
  - Restructure example model files
- Introduce tree label provider for .tasklist files
- Update VSCode workspace (include server folders separately to access launch configs and tasks)
- Update build
  - Update outdated Jenkinsfile
  - Add checkstyle to m2 build and project-template builds

Resolves #47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndoschek ndoschek

Labels
enhancement New feature or request glsp modelserver EMF.cloud Model Server GLSP Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#47 Update project-template to latest versions eclipse-emfcloud/modelserver-glsp-integration
1 participant
@ndoschek