Perform clean code of bundles/org.eclipse.equinox.security

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/auth/ConfigurationFederator.java

@@ -29,8 +29,8 @@ public class ConfigurationFederator extends Configuration {
 	// events
 	private Configuration[] federatedConfigs = null;
 
-	private Hashtable<String, AppConfigurationEntry[]> configCache = new Hashtable<>(5);
-	private Hashtable<String, String> configToProviderMap = new Hashtable<>(5);
+	private final Hashtable<String, AppConfigurationEntry[]> configCache = new Hashtable<>(5);
+	private final Hashtable<String, String> configToProviderMap = new Hashtable<>(5);
 
 	final private Configuration defaultConfiguration;
 

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/auth/SecureContext.java

@@ -25,11 +25,11 @@
 
 public class SecureContext implements ILoginContext {
 
-	private String configName;
+	private final String configName;
 	private LoginContext loginContext;
-	private CallbackHandler handler;
+	private final CallbackHandler handler;
 
-	private SecurityEventsManager eventsManager = new SecurityEventsManager();
+	private final SecurityEventsManager eventsManager = new SecurityEventsManager();
 	private boolean loggedIn = false;
 
 	public SecureContext(String configugationName) {

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/auth/SecurePlatformInternal.java

@@ -32,7 +32,7 @@ public class SecurePlatformInternal {
 	private static final String PROVIDER_URL_BASE = "login.config.url.";//$NON-NLS-1$
 	private static final int MAX_PROVIDER_URL_COUNT = 777; // arbitrary upper limit on the number of provider URLs
 	private Configuration defaultConfiguration;
-	private ExtCallbackHandlerLoader callbackHandlerLoader = new ExtCallbackHandlerLoader();
+	private final ExtCallbackHandlerLoader callbackHandlerLoader = new ExtCallbackHandlerLoader();
 
 	private boolean running = false;
 	private static final SecurePlatformInternal s_instance = new SecurePlatformInternal();

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/auth/events/SecurityEventsManager.java

@@ -20,7 +20,7 @@
 
 public class SecurityEventsManager {
 
-	private Vector<ILoginContextListener> listeners = new Vector<>(5);
+	private final Vector<ILoginContextListener> listeners = new Vector<>(5);
 
 	synchronized public void addListener(ILoginContextListener listener) {
 		listeners.add(listener);

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/PasswordProviderSelector.java

@@ -43,7 +43,7 @@ public class PasswordProviderSelector implements IRegistryEventListener {
 	final private static String HINTS_NAME = "hint";//$NON-NLS-1$
 	final private static String HINT_VALUE = "value";//$NON-NLS-1$
 
-	private Map<String, PasswordProviderModuleExt> modules = new HashMap<>(5); // cache of modules found
+	private final Map<String, PasswordProviderModuleExt> modules = new HashMap<>(5); // cache of modules found
 
 	public class ExtStorageModule {
 		public String moduleID;

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesContainer.java

@@ -74,7 +74,7 @@
  */
 public class SecurePreferencesContainer implements IPreferencesContainer {
 
-	private Map<SecurePreferences, SecurePreferencesWrapper> wrappers = new HashMap<>(); // node ->
+	private final Map<SecurePreferences, SecurePreferencesWrapper> wrappers = new HashMap<>(); // node ->
 																							// SecurePreferencesWrapper
 
 	final private Map<Object, Object> options;

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/SecurePreferencesRoot.java

@@ -77,9 +77,9 @@ public class SecurePreferencesRoot extends SecurePreferences implements IStorage
 
 	private boolean modified = false;
 
-	private JavaEncryption cipher = new JavaEncryption();
+	private final JavaEncryption cipher = new JavaEncryption();
 
-	private Map<String, PasswordExt> passwordCache = new HashMap<>(5); // cached passwords: module ID -> PasswordExt
+	private final Map<String, PasswordExt> passwordCache = new HashMap<>(5); // cached passwords: module ID -> PasswordExt
 
 	public SecurePreferencesRoot(URL location) throws IOException {
 		super(null, null);

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/friends/PasswordProviderDescription.java

@@ -22,11 +22,11 @@ public class PasswordProviderDescription {
 
 	static final private String EMPTY_STRING = ""; //$NON-NLS-1$
 
-	private int priority;
-	private String id;
-	private String name;
-	private String description;
-	private List<String> hints;
+	private final int priority;
+	private final String id;
+	private final String name;
+	private final String description;
+	private final List<String> hints;
 
 	public PasswordProviderDescription(String name, String id, int priority, String description, List<String> hints) {
 		this.id = id;

bundles/org.eclipse.equinox.security/src/org/eclipse/equinox/internal/security/storage/friends/ReEncrypter.java

@@ -32,8 +32,8 @@
 public class ReEncrypter {
 
 	private static class TmpElement {
-		private String path; // absolute node path
-		private Map<String, String> values; // <String>key -> <String>value
+		private final String path; // absolute node path
+		private final Map<String, String> values; // <String>key -> <String>value
 
 		public TmpElement(String path, Map<String, String> values) {
 			this.path = path;
@@ -53,7 +53,7 @@ public Map<String, String> getValues() {
 	final private String moduleID;
 	private boolean processedOK = true;
 
-	private ArrayList<TmpElement> elements = new ArrayList<>(); // List<TmpElement>
+	private final ArrayList<TmpElement> elements = new ArrayList<>(); // List<TmpElement>
 
 	public ReEncrypter(ISecurePreferences prefs, String moduleID) {
 		this.moduleID = moduleID;