Use PrecisionPoint instead of Point to handle deprecation warning #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azoitl
reviewed
Mar 17, 2024
| @@ -67,11 +68,11 @@ protected void handleCollision(PointList points, int index) { | |||
| Point bendPoint; | |||
|
|
|||
| if (index % 2 == 0) { | |||
| bendPoint = new Point(midPoint.x + (int) ((index / 2.0) * -1.0 * ySeparation), | |||
| midPoint.y + (int) ((index / 2.0) * xSeparation)); | |||
| bendPoint = new PrecisionPoint(midPoint.x + (index / 2) * (-1 * ySeparation), | |||
There was a problem hiding this comment.
I think we should move (index/2) to a stack variable. Would make for me the code better readable, and the I wouldn't have made the wrong clean-up if it would have been that way.
There was a problem hiding this comment.
Instead of having a separate variable, I can also just have it be part of the calculation for the xSeparation and ySeparation.
This commit partially reverts fd75841 and uses PrecisionPoints instead of Points in the FanRouter class, to store the bend point. Note that because the mid point is a plain point, the equality check is done using the integer coordinates. Resolves eclipse-gef#383
azoitl
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially reverts fd75841 and uses PrecisionPoints instead of Points in the FanRouter class, to store the bend point.
Note that because the mid point is a plain point, the equality check is done using the integer coordinates.
Resolves #383