Changed RulerLayout to directly inherit from AbstractLayout #418 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wiresketch thx in advance for cross checking. |
…ef#418 RulerLayout inherited from XYLayout. The later assumed that children constraint are rectangles. As this is not valid for RulerLayouts the RulerLayout was changed to inherit from AstractLayout and use its own constraint map with Integers. Fixes eclipse-gef#418
ptziegler
reviewed
Apr 12, 2024
ptziegler
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RulerLayoutinherited fromXYLayout. The later assumed that children constraint are rectangles. As this is not valid forRulerLayouts theRulerLayoutwas changed to inherit fromAbstractLayoutand use its own constraint map with Integers.Fixes #418