Remove deprecation from getDistanceOrthogonal #21

[azoitl]

getDistanceOrthogonal is used in several places in GEF. There is no straight forward replacement. To reason for deprecation is precision of subclasses. As there is only one subclass with higher precision an improved version of that method is added there. Furthermore the impact on precision will anyhow only happen if both sides are PrecisionPoints.

#21

[ptziegler]

I agree that it doesn't make sense to deprecate getDistanceOrthogonal(), but not e.g. getDistanceSquared(), which suffers from the same problem.

That said: I'm not sure if it makes sense to override the method in PrecisePoint, given that you still have the imprecision due to the cast to int. Perhaps it's better to create a getPreciseDistanceOrthogonal(Point) / getDistanceOrthorgonal(PrecisionPoint) method?

[azoitl]

That said: I'm not sure if it makes sense to override the method in PrecisePoint, given that you still have the imprecision due to the cast to int. Perhaps it's better to create a getPreciseDistanceOrthogonal(Point) / getDistanceOrthorgonal(PrecisionPoint) method?

I don't think this makes much sense. The reason I overwrote it is to reduce rounding errors for the deltas and sums. returning a double would mostly only be needed of you sum-up several of the distances. But what could make sense is to round the result instead of casting it to int. What do you think?