-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLSP-975 Move glsp-server types into protocol packages #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces. This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly. Contributed on behalf of STMicroelectronics Part of eclipse-glsp/glsp#975
tortmayr
added a commit
to eclipse-glsp/glsp-server-node
that referenced
this pull request
Apr 24, 2023
- Introduce a common subclass for jsonrpc based ServerLaunchers - Move out jsonrpc implementation details from `GLSPServer` implementation into the `JsonRpcGLSPServerLauncher`. This ensures that the Server implementation itself is independent from the chosen communication channel and can reused for other use cases like direct invocation in a node backend or orthogonal communication channels like REST or gRPC. - Update to latest @eclipse-glsp/protocol version and consume shared server interface types from there - Ensure that the `@eclipse-glsp-examples/workflow-server` package is properly indexed - Add entry points for browser and node - Move rpc-server initialization out of index files into app files. Also: Update example applications to ensure that promise rejections/errors are properly catched. Part of eclipse-glsp/glsp#975 Requires eclipse-glsp/glsp-client#245 Contributed on behalf of STMicroelectronics
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Apr 24, 2023
-Introduce a new `GLSPNodeServerContribution` that can be used in scenarios where the GLSPServer should be running directly in the backend - Update to latest protocol version to make use of the newly exposed server types. - Update lauch configs,tasks and scripts to also cover the new integrated use case. - Add a flag to the workflow-backend-module to be able to switch between the default and integrated usecase Update linking script to also properly link the node-server packages - Move `ChannelConnection` into common package to also resuse it in the backend Part of eclipse-glsp/glsp#975 Requires eclipse-glsp/glsp-client#245 Requires eclipse-glsp/glsp-server-node#44 Contributed on behalf of STMicroelectronics
sgraband
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @tortmayr! LGTM 👍
tortmayr
added a commit
that referenced
this pull request
May 3, 2023
Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces. This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly. Contributed on behalf of STMicroelectronics Part of eclipse-glsp/glsp#975
tortmayr
added a commit
to eclipse-glsp/glsp-server-node
that referenced
this pull request
May 3, 2023
- Introduce a common subclass for jsonrpc based ServerLaunchers - Move out jsonrpc implementation details from `GLSPServer` implementation into the `JsonRpcGLSPServerLauncher`. This ensures that the Server implementation itself is independent from the chosen communication channel and can reused for other use cases like direct invocation in a node backend or orthogonal communication channels like REST or gRPC. - Update to latest @eclipse-glsp/protocol version and consume shared server interface types from there - Ensure that the `@eclipse-glsp-examples/workflow-server` package is properly indexed - Add entry points for browser and node - Move rpc-server initialization out of index files into app files. Also: Update example applications to ensure that promise rejections/errors are properly catched. Part of eclipse-glsp/glsp#975 Requires eclipse-glsp/glsp-client#245 Contributed on behalf of STMicroelectronics
tortmayr
added a commit
to eclipse-glsp/glsp-server-node
that referenced
this pull request
May 3, 2023
- Introduce a common subclass for jsonrpc based ServerLaunchers - Move out jsonrpc implementation details from `GLSPServer` implementation into the `JsonRpcGLSPServerLauncher`. This ensures that the Server implementation itself is independent from the chosen communication channel and can reused for other use cases like direct invocation in a node backend or orthogonal communication channels like REST or gRPC. - Update to latest @eclipse-glsp/protocol version and consume shared server interface types from there - Ensure that the `@eclipse-glsp-examples/workflow-server` package is properly indexed - Add entry points for browser and node - Move rpc-server initialization out of index files into app files. Also: Update example applications to ensure that promise rejections/errors are properly catched. Part of eclipse-glsp/glsp#975 Requires eclipse-glsp/glsp-client#245 Contributed on behalf of STMicroelectronics
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
May 5, 2023
-Introduce a new `GLSPNodeServerContribution` that can be used in scenarios where the GLSPServer should be running directly in the backend - Update to latest protocol version to make use of the newly exposed server types. - Update lauch configs,tasks and scripts to also cover the new integrated use case. - Add a flag to the workflow-backend-module to be able to switch between the default and integrated usecase Update linking script to also properly link the node-server packages - Move `ChannelConnection` into common package to also resuse it in the backend Part of eclipse-glsp/glsp#975 Requires eclipse-glsp/glsp-client#245 Requires eclipse-glsp/glsp-server-node#44 Contributed on behalf of STMicroelectronics
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
May 5, 2023
* GLSP-975 Support for servers directly in the Theia backend -Introduce a new `GLSPNodeServerContribution` that can be used in scenarios where the GLSPServer should be running directly in the backend - Update to latest protocol version to make use of the newly exposed server types. - Update lauch configs,tasks and scripts to also cover the new integrated use case. - Add a flag to the workflow-backend-module to be able to switch between the default and integrated usecase Update linking script to also properly link the node-server packages - Move `ChannelConnection` into common package to also resuse it in the backend Part of eclipse-glsp/glsp#975 Requires eclipse-glsp/glsp-client#245 Requires eclipse-glsp/glsp-server-node#44 Contributed on behalf of STMicroelectronics
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
) Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces. This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly. Contributed on behalf of STMicroelectronics Part of eclipse-glsp/glsp#975
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
) Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces. This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly. Contributed on behalf of STMicroelectronics Part of eclipse-glsp/glsp#975
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that the
@eclipse-glsp/protocol
package also provides the glsp server interfaces. This allows type reusage in usecases where the GLSP server is not running in an external process and is instead accessed directly.Contributed on behalf of STMicroelectronics
Part of eclipse-glsp/glsp#975