Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-975 Move glsp-server types into protocol packages #245

Merged
merged 1 commit into from
May 3, 2023

Conversation

tortmayr
Copy link
Contributor

Ensures that the @eclipse-glsp/protocol package also provides the glsp server interfaces. This allows type reusage in usecases where the GLSP server is not running in an external process and is instead accessed directly.

Contributed on behalf of STMicroelectronics
Part of eclipse-glsp/glsp#975

Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces.
This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly.

Contributed on behalf of STMicroelectronics
Part of eclipse-glsp/glsp#975
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this pull request Apr 24, 2023
- Introduce a common subclass for jsonrpc based ServerLaunchers
- Move out jsonrpc implementation details from `GLSPServer` implementation into the `JsonRpcGLSPServerLauncher`.
 This ensures that the Server implementation itself is independent from the chosen communication channel and can reused for other use cases like direct invocation in a node backend or orthogonal communication channels like REST or gRPC.
- Update to latest @eclipse-glsp/protocol version and consume shared server interface types from there

- Ensure that the `@eclipse-glsp-examples/workflow-server` package is properly indexed
- Add entry points for browser and node 
- Move rpc-server initialization out of index files into app files. 


Also: Update example applications to ensure that promise rejections/errors are properly catched.

Part of eclipse-glsp/glsp#975

Requires eclipse-glsp/glsp-client#245

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request Apr 24, 2023
-Introduce a new `GLSPNodeServerContribution` that can be used in scenarios where the GLSPServer should be running directly in the backend
- Update to latest protocol version to make use of the newly exposed server types.
- Update lauch configs,tasks and scripts to also cover the new integrated use case.
- Add a flag to the workflow-backend-module to be able to switch between the default and integrated usecase
Update linking script to also properly link the node-server packages
- Move `ChannelConnection` into common package to also resuse it in the backend

Part of eclipse-glsp/glsp#975

Requires eclipse-glsp/glsp-client#245
Requires eclipse-glsp/glsp-server-node#44

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr requested a review from sgraband April 24, 2023 14:36
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes @tortmayr! LGTM 👍

@tortmayr tortmayr merged commit 15c2f6f into master May 3, 2023
@tortmayr tortmayr deleted the issues/975 branch May 3, 2023 09:57
tortmayr added a commit that referenced this pull request May 3, 2023
Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces.
This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly.

Contributed on behalf of STMicroelectronics
Part of eclipse-glsp/glsp#975
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this pull request May 3, 2023
- Introduce a common subclass for jsonrpc based ServerLaunchers
- Move out jsonrpc implementation details from `GLSPServer` implementation into the `JsonRpcGLSPServerLauncher`.
 This ensures that the Server implementation itself is independent from the chosen communication channel and can reused for other use cases like direct invocation in a node backend or orthogonal communication channels like REST or gRPC.
- Update to latest @eclipse-glsp/protocol version and consume shared server interface types from there

- Ensure that the `@eclipse-glsp-examples/workflow-server` package is properly indexed
- Add entry points for browser and node 
- Move rpc-server initialization out of index files into app files. 


Also: Update example applications to ensure that promise rejections/errors are properly catched.

Part of eclipse-glsp/glsp#975

Requires eclipse-glsp/glsp-client#245

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-server-node that referenced this pull request May 3, 2023
- Introduce a common subclass for jsonrpc based ServerLaunchers
- Move out jsonrpc implementation details from `GLSPServer` implementation into the `JsonRpcGLSPServerLauncher`.
 This ensures that the Server implementation itself is independent from the chosen communication channel and can reused for other use cases like direct invocation in a node backend or orthogonal communication channels like REST or gRPC.
- Update to latest @eclipse-glsp/protocol version and consume shared server interface types from there

- Ensure that the `@eclipse-glsp-examples/workflow-server` package is properly indexed
- Add entry points for browser and node 
- Move rpc-server initialization out of index files into app files. 


Also: Update example applications to ensure that promise rejections/errors are properly catched.

Part of eclipse-glsp/glsp#975

Requires eclipse-glsp/glsp-client#245

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request May 5, 2023
-Introduce a new `GLSPNodeServerContribution` that can be used in scenarios where the GLSPServer should be running directly in the backend
- Update to latest protocol version to make use of the newly exposed server types.
- Update lauch configs,tasks and scripts to also cover the new integrated use case.
- Add a flag to the workflow-backend-module to be able to switch between the default and integrated usecase
Update linking script to also properly link the node-server packages
- Move `ChannelConnection` into common package to also resuse it in the backend

Part of eclipse-glsp/glsp#975

Requires eclipse-glsp/glsp-client#245
Requires eclipse-glsp/glsp-server-node#44

Contributed on behalf of STMicroelectronics
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this pull request May 5, 2023
* GLSP-975 Support for servers directly in the Theia backend

-Introduce a new `GLSPNodeServerContribution` that can be used in scenarios where the GLSPServer should be running directly in the backend
- Update to latest protocol version to make use of the newly exposed server types.
- Update lauch configs,tasks and scripts to also cover the new integrated use case.
- Add a flag to the workflow-backend-module to be able to switch between the default and integrated usecase
Update linking script to also properly link the node-server packages
- Move `ChannelConnection` into common package to also resuse it in the backend

Part of eclipse-glsp/glsp#975

Requires eclipse-glsp/glsp-client#245
Requires eclipse-glsp/glsp-server-node#44

Contributed on behalf of STMicroelectronics
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
)

Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces.
This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly.

Contributed on behalf of STMicroelectronics
Part of eclipse-glsp/glsp#975
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
)

Ensures that the `@eclipse-glsp/protocol` package also provides the glsp server interfaces.
This allows type reusage in usecases where the GLSP server is not connected via JSON-RPC and is instead accessed directly.

Contributed on behalf of STMicroelectronics
Part of eclipse-glsp/glsp#975
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants