Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1082: Fix edge edit #273

Merged
merged 1 commit into from
Aug 8, 2023
Merged

GLSP-1082: Fix edge edit #273

merged 1 commit into from
Aug 8, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Aug 7, 2023

Update selection-mouse listener. The base mouse listener in sprotty has been reworked. This change adjusts the RankedSelectMouseListener to the new basae implementation and overrides it where necessary to avoid disposal of SetEditModeActions

Fixes eclipse-glsp/glsp#1082

Update selection-mouse listener. The base mouse listener in sprotty has been reworked.
This change adjusts the `RankedSelectMouseListener` to the new basae implementation and overrides it where necessary to avoid disposal of `SetEditModeActions`

Fixes eclipse-glsp/glsp#1082
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit cc57a50 into master Aug 8, 2023
@tortmayr tortmayr deleted the issues/1082 branch August 8, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edge edit is broken after GLSP-900
2 participants