GLSP-1116 Revise model loading #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
planger
reviewed
Sep 12, 2023
- Refactor diagram loader
- Remove dispatching of temporary empty set model action and instead call `actionDispatcher.initialize()` earlier which also dispatches an empty set model action under the hood
- Add additional `postModelInitalization` hook for startup services that want execute logic after the model is fully initialized
- Rework `ModelInitializationConstraint`
- Provide `onInitialized` override that allows sync registration of listener callbacks
- Refactor `setCompleted` method and remove the possiblity to set the initialized state to false.
Model initialization is a one-time action. Once initialized there should be no way to "uninitialize" the constraint
- Provide test cases
- Add `dispatchOnceModelInitialized` utility function to action dispatcher
- Ensure that type hints are requested after the model has been initialized
Part-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606
planger
approved these changes
Sep 13, 2023
-Extend `initializeClientSession` request to also specific the set of client action kinds. This way the server knows which actions should be sent to the client -Adapt `GLSPModelSource´ to retrieve the client actions before sending the `initializeClientSession` request - Add customized `GLSPActionHandlerRegistry` which provides a query method to retrieve all handled action kinds Part of eclipse-glsp/glsp/issues/1117
|
@planger I have also added change for GLSP-1117 and GLSP-1071 to this PR. Since these are also changes that require updatse across all integration projects I would rather do this all in one go instead of having to create multiple PRs per repository. Could you please re-review? |
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
* GLSP-1116 Revise model loading
- Refactor diagram loader
- Remove dispatching of temporary empty set model action and instead call `actionDispatcher.initialize()` earlier which also dispatches an empty set model action under the hood
- Add additional `postModelInitalization` hook for startup services that want execute logic after the model is fully initialized
- Rework `ModelInitializationConstraint`
- Provide `onInitialized` override that allows sync registration of listener callbacks
- Refactor `setCompleted` method and remove the possiblity to set the initialized state to false.
Model initialization is a one-time action. Once initialized there should be no way to "uninitialize" the constraint
- Provide test cases
- Add `dispatchOnceModelInitialized` utility function to action dispatcher
- Ensure that type hints are requested after the model has been initialized
Part-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606
* GLSP-1117: Remove need for explicit definition of client actions
-Extend `initializeClientSession` request to also specific the set of client action kinds. This way the server knows which actions should be sent to the client
-Adapt `GLSPModelSource´ to retrieve the client actions before sending the `initializeClientSession` request
- Add customized `GLSPActionHandlerRegistry` which provides a query method to retrieve all handled action kinds
Part of eclipse-glsp/glsp/issues/1117
* GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp#1071
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
* GLSP-1116 Revise model loading
- Refactor diagram loader
- Remove dispatching of temporary empty set model action and instead call `actionDispatcher.initialize()` earlier which also dispatches an empty set model action under the hood
- Add additional `postModelInitalization` hook for startup services that want execute logic after the model is fully initialized
- Rework `ModelInitializationConstraint`
- Provide `onInitialized` override that allows sync registration of listener callbacks
- Refactor `setCompleted` method and remove the possiblity to set the initialized state to false.
Model initialization is a one-time action. Once initialized there should be no way to "uninitialize" the constraint
- Provide test cases
- Add `dispatchOnceModelInitialized` utility function to action dispatcher
- Ensure that type hints are requested after the model has been initialized
Part-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606
* GLSP-1117: Remove need for explicit definition of client actions
-Extend `initializeClientSession` request to also specific the set of client action kinds. This way the server knows which actions should be sent to the client
-Adapt `GLSPModelSource´ to retrieve the client actions before sending the `initializeClientSession` request
- Add customized `GLSPActionHandlerRegistry` which provides a query method to retrieve all handled action kinds
Part of eclipse-glsp/glsp/issues/1117
* GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp#1071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSP-1116 Revise model loading
RequestModelActionas request actionactionDispatcher.initialize()earlier which also dispatches an empty set model action under the hoodModelInitializationConstraintActionDispatcherthe initialization state is now controlled by the diagram loaderonInitializedevent and a callback function for on-time invocationonceInitializeddispatchOnceModelInitializedutility function to action dispatcherPart-of: eclipse-glsp/glsp#1116
Part-of: eclipse-glsp/glsp#606
GLSP-1117: Remove need for explicit definition of client actions
-Extend
initializeClientSessionrequest to also specific the set of client action kinds. This way the server knows which actions should be sent to the client-Adapt
GLSPModelSource´ to retrieve the client actions before sending theinitializeClientSession` requestGLSPActionHandlerRegistrywhich provides a query method to retrieve all handled action kindsPart of eclipse-glsp/glsp/issues/1117
GLSP-1071: Rename ServerStatus/ServerMessage action
Part of eclipse-glsp/glsp#1071
Requires: eclipse-glsp/glsp-server#211