Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid dependency on 'chai' through exported index #321

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Avoid dependency on 'chai' through exported index #321

merged 1 commit into from
Mar 6, 2024

Conversation

martin-fleck-at
Copy link
Contributor

@martin-fleck-at martin-fleck-at commented Mar 4, 2024 •
edited by tortmayr
Loading

What it does

Fixes eclipse-glsp/glsp#1269

How to test

Verify through another package that does not have chai but still imports types and functions from the main package that it properly works.

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

tortmayr
tortmayr approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tortmayr tortmayr merged commit 03ec8b6 into master Mar 6, 2024
5 of 6 checks passed
@tortmayr tortmayr deleted the issues/1269 branch March 6, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adopters need to have 'chai' as a dependency because of test-util.ts
2 participants
@martin-fleck-at @tortmayr