Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1393 Update changelog #393

Merged
merged 1 commit into from
Oct 21, 2024
Merged

GLSP-1393 Update changelog #393

merged 1 commit into from
Oct 21, 2024

Conversation

ivy-lli
Copy link
Contributor

@ivy-lli ivy-lli commented Oct 21, 2024

While updating an existing glsp-client from 2.2.1 to 2.3.0-next.381 I ran into the changes from eclipse-glsp/glsp#1393, which were not documented in the Changelog.

What it does

How to test

--

Follow-ups

--

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this commit. 👍🏼
In general, its not necessary to update the changelog on/after every PR. We mark changes that are relevant for the log in the PR description and then do a bulk changelog update before a release.
Of course you are free to also provide individual changelog updates but just keep in mind that its not strictly necessary.

@tortmayr tortmayr merged commit 6953835 into master Oct 21, 2024
7 checks passed
@tortmayr tortmayr deleted the changelog/1393 branch October 21, 2024 11:27
@ivy-lli
Copy link
Contributor Author

ivy-lli commented Oct 21, 2024

Good to know 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants