Add validation marker and navigator tests #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tortmayr I'm not sure why https://github.com/eclipse-glsp/glsp-playwright/actions/runs/10041871309 succeeded - there were failures 🤔 |
|
@haydar-metin The problem is the continue-on-error condition in the playwright test step. This is needed to also upload the test report when tests failed. But it also as the side effect of reporting the job as successful. I openend #16 which should fix that issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Improves the test cases for validation and navigation.
Further improves the API of the GLSP-Playwright framework by:
toHaveSelected,toBeUnselectedfor easier tests.capabilitiesto their respective feature folder inglsp/featuresHow to test
Execute
yarn testVSCode has no support for
Marker NavigationFollow-ups
Changelog