Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#509 Implement ELK autolayout support #2

Merged
merged 2 commits into from
Jan 26, 2022
Merged

#509 Implement ELK autolayout support #2

merged 2 commits into from
Jan 26, 2022

Conversation

tortmayr
Copy link
Contributor

  • Provide a new @eclipse-glsp/layout-elk package that provides the glue code to integrate an ELK Layout Engine into GLSP node servers.
  • Add example layout engine using elk-layered algorithm to workflow example.

Also:

  • Implement support for async operation handlers by using MaybePromises
  • Add missing default exports to index.ts (server-node)

Contributed on behalf of STMicroelectronics

@tortmayr
#509 Implement ELK autolayout support
15b54c3 
- Provide a new `@eclipse-glsp/layout-elk` package that provides the glue code to integrate an ELK Layout Engine into GLSP node servers.
- Add example layout engine using elk-layered algorithm to workflow example.

Also: 
- Implement support for async operation handlers by using `MaybePromise`s
- Add missing default exports to index.ts (server-node)

Contributed on behalf of STMicroelectronics
@tortmayr tortmayr requested a review from sgraband January 26, 2022 14:48
sgraband
sgraband reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tortmayr!

Changes work great and the code looks good. The only thing i think we should change, is the link in the Changelog. The other comments are only typos that my spell checker found, so great job 🙂

CHANGELOG.md Outdated Show resolved Hide resolved
packages/layout-elk/src/basic-type-mapper.ts Outdated Show resolved Hide resolved
packages/layout-elk/src/basic-type-mapper.ts Outdated Show resolved Hide resolved
packages/layout-elk/src/glsp-element-filter.ts Outdated Show resolved Hide resolved
packages/layout-elk/src/basic-type-mapper.ts Outdated Show resolved Hide resolved
packages/layout-elk/src/basic-type-mapper.ts Outdated Show resolved Hide resolved
packages/layout-elk/src/basic-type-mapper.ts Outdated Show resolved Hide resolved
@tortmayr
Copy link
Contributor Author

Thanks for the fast review Simon. I addressed the open issues and the PR should now be ready to merge

@tortmayr tortmayr merged commit 66aad6e into main Jan 26, 2022
@tortmayr tortmayr deleted the issues/509 branch January 26, 2022 21:59
@tortmayr tortmayr restored the issues/509 branch January 26, 2022 21:59
@tortmayr tortmayr mentioned this pull request Jan 26, 2022
Closed
@tortmayr tortmayr deleted the issues/509 branch December 10, 2022 01:05
yentelmanero added a commit to yentelmanero/glsp-server-node that referenced this pull request Feb 1, 2024
@yentelmanero
Implemented suggested changes from PR eclipse-glsp#2
6a88438
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgraband sgraband sgraband left review comments

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @sgraband