GH-639 Align ModelState API with Java GLSP Server API #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `updateRoot` method and make root setter protected - Update changelog Fixes eclipse-glsp/glsp#639
sgraband
reviewed
May 23, 2022
CHANGELOG.md
Outdated
|
|
||
| ### Changes | ||
|
|
||
| - [diagram] Implement LayoutEngine API for server-side autolayouting & provide an integration package for layout engines based on ELK. [#509](https://github.com/eclipse-glsp/glsp-server-node/pull/2) [#514](https://github.com/eclipse-glsp/glsp-server-node/pull/5) - Contributed on behalf of STMicroelectronics | ||
| - [core] Implement `dispatchOnNextUpdate` method that enables queuing of actions that should be dispatched after the next graphical model update. [#1](https://github.com/eclipse-glsp/glsp-server-node/pull/1) |
There was a problem hiding this comment.
This was also Contributed on behalf of STMicroelectronics
CHANGELOG.md
Outdated
|
|
||
| Inception of the Node GLSP Server. | ||
| This project provides the Node based server component for the Eclipse Graphical Language Platform (GLSP). | ||
| The implementation of this server is aligned with the default Java based [GLSP Server](https://github.com/eclipse-glsp/glsp-server). | ||
| The initial initial implementation was contributed on behalf of STMicroelectronics. | ||
| The [initial implementation](https://github.com/eclipse-glsp/glsp-server-node/commit/4fba8e8beef07798a7eff27c9c04ca68583e5960) has been contributed on behalf of STMicroelectronics. |
There was a problem hiding this comment.
Suggested change
| The [initial implementation](https://github.com/eclipse-glsp/glsp-server-node/commit/4fba8e8beef07798a7eff27c9c04ca68583e5960) has been contributed on behalf of STMicroelectronics. | |
| The [initial implementation](https://github.com/eclipse-glsp/glsp-server-node/commit/4fba8e8beef07798a7eff27c9c04ca68583e5960) was contributed on behalf of STMicroelectronics. |
Nitpick, but i think the process is over, hence was is more suited than has been.
|
Thanks for the fast review Simon. I pushed an update with the requested changes. |
sgraband
approved these changes
May 23, 2022
tortmayr
added a commit
to eclipse-glsp/glsp-website-source
that referenced
this pull request
May 23, 2022
Update node code snippet to conform to changes from eclipse-glsp/glsp-server-node#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
updateRootmethod and make root setter protectedFixes Align ModelState API of node server with Java server glsp#639