Refactor packages and provide dedicated browser and node runtimes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
force-pushed
the
browser-runtime
branch
from
707b493 to
db77039
Compare
- Move shared code into common package; add dedicated browser and node packages - Update package.json to provide entry points for both node and browser - Refactor `@eclipse-glsp-examples/workflow-server` following the same pattern - Rename `@eclipse-glsp/server-node` package to `@eclipse-glsp/server` and provide import entry points for node and browser - Add webpack config to enable both bundling for node and the browser - Update changelog - Add bundle step for browser-env to Jenkins build Fixes eclipse-glsp/glsp#884
tortmayr
force-pushed
the
browser-runtime
branch
from
db77039 to
614e5fd
Compare
xai
suggested changes
Jan 27, 2023
There was a problem hiding this comment.
Looks good and works great with glsp-theia-integration and glsp-vscode-integration 👍
I also tested debugging the workflow example and the node backend.
Really minor comments:
- The main README still refers to
@eclipse-glsp/server-node - We could hint to the minimum nodejs requirement (16) in the README and maybe even include a .nvmrc to suggest a tested version of node to the user.
|
Thanks Olaf, I have updated the README and fixed the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move shared code into common package, add dedicated browser and node packages
Update package.json to provide entry points for both node and browser
Refactor
@eclipse-glsp-examples/workflow-serverfollowing the same patternAdd webpack config to enable both bundling for node and the browser
Update changelog
Add bundle step for browser-env to Jenkins build
Fixes eclipse-glsp/glsp#884