Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#514 Refactor GlspElkLayoutEngine #5

Merged
merged 2 commits into from
Feb 3, 2022
Merged

#514 Refactor GlspElkLayoutEngine #5

merged 2 commits into from
Feb 3, 2022

Commits on Feb 3, 2022

  1. #514 Refactor GlspElkLayoutEngine 

    - Refactor the `GlspElkLayoutEngine` and related concepts to properly support layout computation for ports. In this process we also opted out of trying to reuse the existing `SprottyElkLayoutEngine` and instead implement a new layout engine specifically for the GLSP graphmodel. This implementation is more in line with the Java ELK-Layout Engine and implements similar features like automatic detection of common ancestors of edge source/targets to correctly transform them in the ELK graph.

- Removes the no longer needed `BasicTypeMapper`

Also: 
- Provide utility functions for querying parent elements of a given element that match a predicate. (gmodel-util.ts)
- Only rerexport the the subset of types that are really needed from "sprotty-elk" to avoid unncessary naming clashes.
- Add jsdoc for `GModelSerializer`
- Fix implementation of `getAllEdges` in `GModelIndex`
- Remove unused (and unset) `source` and `target` references in `GEdge`

Contributed on behalf of STMicroelectronics
    @tortmayr
    tortmayr committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    54b5138 View commit details
    Browse the repository at this point in the history

  2. Address review feedback

    @tortmayr
    tortmayr committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    b4b968c View commit details
    Browse the repository at this point in the history