Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for server progress reporting #52

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Add support for server progress reporting #52

merged 2 commits into from
Jul 13, 2023

Conversation

planger
Copy link
Member

@planger planger commented Jul 12, 2023 •
edited
Loading

@planger planger requested a review from tortmayr July 12, 2023 15:15
@planger planger mentioned this pull request Jul 12, 2023
Merged
@planger planger force-pushed the planger/issues/1019 branch from 807d23e to a9ccf2b Compare July 12, 2023 15:34
tortmayr
tortmayr approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works like a charm. 👍🏼
I tested it by adding a 5 second timeout to the RequestModelActionHandler, then updated the progress to 50 percent and after 5 more seconds end the progress reporting.

@planger planger force-pushed the planger/issues/1019 branch from a9ccf2b to ca6620e Compare July 13, 2023 12:13
@planger planger mentioned this pull request Jul 13, 2023
Closed
7 tasks
@planger planger force-pushed the planger/issues/1019 branch from f3b403a to eadc605 Compare July 13, 2023 18:44
@planger planger merged commit ea31916 into main Jul 13, 2023
@planger planger deleted the planger/issues/1019 branch July 13, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planger @tortmayr