Adapt to latest protocol changes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# GLSP-1116 Revise model loading - Refactor `ModelSubmissionHandler` to support proper handling of the `RequestModelAction` as real request action Part-of: eclipse-glsp/glsp#1116 # GLSP-1117: Remove need for explicit definition of client actions Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client - Add `clientActions` array to `InitializeClientSessionParams`. This means the client now has to pass the action kinds it wants to handle as part of the initalize request - Replace `ClientActionHandler` with `ClientActionForwader` a separate component that is not part of the server-side action handlers. - Remove `configureClientActions` method from `DiagramModule` as the explicit configuration is no longer needed Part of eclipse-glsp/glsp/issues/1117 #GLSP-1071: Rename ServerStatus/ServerMessage action Part of eclipse-glsp/glsp/issues/1071
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLSP-1116 Revise model loading
ModelSubmissionHandlerto support proper handling of theRequestModelActionas real request actionPart-of: Model initialization behavior is flaky glsp#1116
GLSP-1117: Remove need for explicit definition of client actions
Refactor the base GLSP protocol to allow the client to tell the server which actions it is going to handle i.e. which actions should be forwarded to the client
clientActionsarray toInitializeClientSessionParams. This means the client now has to pass the action kinds it wants to handle as part of the initalize requestClientActionHandlerwithClientActionForwadera separate component that is not part of the server-side action handlers.configureClientActionsmethod fromDiagramModuleas the explicit configuration is no longer neededPart of eclipse-glsp/glsp/issues/1117
GLSP-1071: Rename ServerStatus/ServerMessage action Part of eclipse-glsp/glsp/issues/1071