#432#257 Align server action with client protocol #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2021
tortmayr
requested review from
martin-fleck-at
and removed request for
planger
martin-fleck-at
requested changes
Nov 10, 2021
...rg.eclipse.glsp.server/src/org/eclipse/glsp/server/features/validation/SetMarkersAction.java
Show resolved
Hide resolved
tortmayr
force-pushed
the
tortmayr/issues/432
branch
from
c27f4a8 to
c7aa93d
Compare
tortmayr
force-pushed
the
tortmayr/issues/432
branch
from
c7aa93d to
c86d0ac
Compare
- Ensure that all request/response actions are implemented as proper request-response action pair - Ensure that getter for optional action properties returns an Optional - Ensure that action properties that have a collection type are always initialized - Rename static action kind constant to `KIND` - Update to latest emfcloud-checkstyle config - Remove model state argument from GModelFactory & NavigationTargetResolver (#458) Closes eclipse-glsp/glsp/issues/458 Closes eclipse-glsp/glsp/issues/432 Part of eclipse-glsp/glsp/issues/257
tortmayr
force-pushed
the
tortmayr/issues/432
branch
from
c86d0ac to
0437f73
Compare
|
@martin-fleck-at I already included the Metadata changes for the upcoming release in this commit (versions, md updates, changelogs etc.). Please review them as well. Thanks! |
martin-fleck-at
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Changes look good to me and everything still works as expected. Thank you for the great work, Tobias! I just have a few minor comments for the new change log, so maybe you can have a look at that but they should not prevent merging and may also be done in a follow-up PR.
tortmayr
force-pushed
the
tortmayr/issues/432
branch
from
ec182aa to
c9a520b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KINDCloses eclipse-glsp/glsp/issues/432
Part of eclipse-glsp/glsp/issues/257