-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#579 Update to log4j 2.17.1 #163
Conversation
- Update to org.apache.logging.log4j version 2.17.1 - Migrate dependencies to log4j2 - Migrate usage of logger to log4j2 and align naming to LOGGER - Migrate log configuration and introduce rolling log file policy - Update target platform to latest 2022-03 release - Adapt fatjar build - Setup fatjar to use multi-release jars to overcome logging issues while jar execution - Fix warnings related to overlapping classes during fatjar generation - Ensure logging is configured for all server use cases on startup - Provide start methods to allow easier log configuration - Add Log4j2Logger redirection for jetty server in case of websocket server usage - This is a copy from the org.apache.logging.log4j/log4j-appserver module, as this is not available as plugin. - Improve help text for CLI usage - Add short program arguments for single letter argument usage - Fix fragment host version for org.eclipse.glsp.graph.test in manifest file - Update README Resolves eclipse-glsp/glsp#579
@ndoschek Cool that the newest libraries are used with this change. Just one thing. I relaxed that glsp depends on log4j with |
Thanks @ivy-cst! I updated my changes and import the packages now instead of requiring the bundle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ndoschek, looks good to me!
I tested building and running the fatjar. That worked fine. 👍
Co-authored-by: Philip Langer <planger@eclipsesource.com>
Thanks @planger, yes I agree - I updated with your suggested change |
* Adaptations for eclipse-glsp/glsp-server#165 * TPD update, see eclipse-glsp/glsp-server#163
* Adaptations for eclipse-glsp/glsp-server#165 * TPD update, see eclipse-glsp/glsp-server#163
* Adaptations for eclipse-glsp/glsp-server#165 * TPD update, see eclipse-glsp/glsp-server#163
* Adaptations for eclipse-glsp/glsp-server#165 * TPD update, see eclipse-glsp/glsp-server#163
- Update to org.apache.logging.log4j version 2.17.1 - Migrate dependencies to log4j2 - Migrate usage of logger to log4j2 and align naming to LOGGER - Migrate log configuration and introduce rolling log file policy - Update target platform to latest 2022-03 release - Adapt fatjar build - Setup fatjar to use multi-release jars to overcome logging issues while jar execution - Fix warnings related to overlapping classes during fatjar generation - Ensure logging is configured for all server use cases on startup - Provide start methods to allow easier log configuration - Add Log4j2Logger redirection for jetty server in case of websocket server usage - This is a copy from the org.apache.logging.log4j/log4j-appserver module, as this is not available as plugin. - Improve help text for CLI usage - Add short program arguments for single letter argument usage - Fix fragment host version for org.eclipse.glsp.graph.test in manifest file - Update README Resolves eclipse-glsp/glsp#579 * Import packages org.apache.logging.log4j.* instead of required bundle * Update README.md Co-authored-by: Philip Langer <planger@eclipsesource.com>
Resolves eclipse-glsp/glsp#579