Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tycho maven version: 2.3.0 => 2.7.5 #180

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Update tycho maven version: 2.3.0 => 2.7.5 #180

merged 2 commits into from
Dec 9, 2022

Conversation

xai
Copy link
Member

@xai xai commented Sep 22, 2022

This is needed to build with maven and Java 17.
Related to this, includePackedArtifacts had to be disabled as it seems to cause issues with Java 14 and higher.

Closes eclipse-glsp/glsp#750

Signed-off-by: Olaf Lessenich olessenich@eclipsesource.com

@xai
Copy link
Member Author

xai commented Oct 6, 2022

I need to have another look at this, there is a currently a mix of tycho-versions in the pom.xml files.

@xai xai marked this pull request as draft October 6, 2022 10:42
@xai xai marked this pull request as ready for review October 6, 2022 12:44
@xai xai requested a review from tortmayr November 4, 2022 16:41
xai added 2 commits December 1, 2022 10:40
@xai
Update tycho maven version: 2.3.0 => 2.7.5
8a1da61 
This is needed to build with maven and Java 17.
Related to this, includePackedArtifacts had to be disabled as it seems
to cause issues with Java 14 and higher.

Closes eclipse-glsp/glsp#750

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
@xai
Adjust targetplatform pom + use default for includePackedArtifacts
bdb014c 
Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
@xai xai requested a review from ndoschek December 1, 2022 09:50
@tortmayr tortmayr removed their request for review December 6, 2022 13:16
ndoschek
ndoschek approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xai, looks good to me, builds with both Java 11 and Java 17 and still works as expected 🎉
Internally (e.g. for compiling) we still use Java 11, I will open up an issue for discussion to use Java 17 throughout the project in the future.

@tortmayr
Copy link
Contributor

tortmayr commented Dec 9, 2022

Internally (e.g. for compiling) we still use Java 11, I will open up an issue for discussion to use Java 17 throughout the project in the future.

I think we discussed this previously and decided that we in general want to support the last two LTS Versions of Java (see also https://endoflife.date/java). That's why the code is still compiling to 11. However, I'm open for discussing this 👍🏼 .

@tortmayr tortmayr merged commit b500d90 into eclipse-glsp:master Dec 9, 2022
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
@xai
Update tycho maven version: 2.3.0 => 2.7.5 (eclipse-glsp#180)
ffdd8d2 
This is needed to build with maven and Java 17.
Related to this, includePackedArtifacts had to be disabled as it seems
to cause issues with Java 14 and higher.

Closes eclipse-glsp/glsp#750

Signed-off-by: Olaf Lessenich <olessenich@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndoschek ndoschek ndoschek approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven build fails when using OpenJDK 17
3 participants
@xai @tortmayr @ndoschek