Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update server.websocket to Jetty 11 #185

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Update server.websocket to Jetty 11 #185

merged 1 commit into from
Jan 20, 2023

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Jan 20, 2023 •
edited
Loading

  • Update default target platform

    • Eclipse 21.03-> 22.12
    • Jetty 9.x -> Jetty 11.0.12
    • LSP4J -> 0.8.0 -> 0.19.0
    • ELK 0.7.0 -> 0.8.1
    • Add slf4j to enable logging in Jetty 10

  • Consume log4j,slf4j and javax.servlet via maven

    • Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version. So we instead use the new target platform features and consume it directly from a maven location

  • Update server.websocket plugin to conform to Jetty API breaks

  • Update to ELK 0.8.1 and remove workaround (Fixes Remove workaround to force guava version once ELK 0.8.0 is released glsp#265)

  • Clean up pom files and consistently use properties for all versions

  • Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.

  • Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

  • Provide a second target for 2021-09 to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics

@tortmayr tortmayr force-pushed the issues/764 branch 2 times, most recently from 02737a7 to f0ad265 Compare January 20, 2023 11:17
@tortmayr
Copy link
Contributor Author

tortmayr commented Jan 20, 2023 •
edited
Loading

Note, in order to use maven locations in the target/tpd files you have to make sure that
-the m2e PDE Integration feature is installed (available via the default eclipse update site)

@tortmayr tortmayr requested a review from planger January 20, 2023 11:22
@tortmayr
Update server.websocket to Jetty 11
eb8cdde 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
planger
planger approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, thank you! I've tested with 2022-12 and 2021-09 TPDs.

@tortmayr tortmayr merged commit ddf7ee6 into master Jan 20, 2023
@tortmayr tortmayr deleted the issues/764 branch January 20, 2023 15:01
tortmayr added a commit that referenced this pull request Jan 20, 2023
@tortmayr
Update server.websocket to Jetty 11 (#185)
b75eade 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
tortmayr added a commit that referenced this pull request Jan 22, 2023
@tortmayr
Update server.websocket to Jetty 11 (#185)
2299c3d 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
@tortmayr
Update server.websocket to Jetty 11 (eclipse-glsp#185)
5de00e2 
- Update default target platform
   - Eclipse 21.03-> 22.12
   - Jetty 9.x -> Jetty 11.0.12
   - LSP4J -> 0.8.0 -> 0.19.0  
   - ELK 0.7.0 -> 0.8.1
   - Add slf4j to enable logging in Jetty 10

- Consume log4j,slf4j and javax.servlet  via maven
   - Jetty websockt requires slf4j 2.0 which is not available via orbit and not compatible with the orbit log4j version.
     So we instead use the new target platform features and consume it directly from a maven location

-  Update server.websocket plugin to conform to Jetty API breaks

- Update to ELK 0.8.1 and remove workaround (Fixes eclipse-glsp/glsp#265)
- Clean up pom files and consistently use properties for all versions
- Remove xtext nature from parent project. Otherwise we get false positives in the Eclipse Problem view.
- Ensure that both the p2 and m2 build use the same version ranges for their dependencies (if possible)

- Provide a second target for 2021-09  to use it as minimal baseline.

Part of eclipse-glsp/glsp#764
Contributed on behalf of STMicroelectronics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove workaround to force guava version once ELK 0.8.0 is released
2 participants
@tortmayr @planger