Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary 'ApplyTaskEditAction' and update operation handlers #191

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

martin-fleck-at
Copy link
Contributor

  • Use 'EditTaskOperation' directly from the client
  • Minor checkstyle cleanup and refactoring for Paste handler
  • Make CutOperationHandler GModel-specific as it returns recording cmd
  • Let LayoutOperationHandler inherit from generic base class
  • Update some JavaDoc

Relates to eclipse-glsp/glsp#864

- Use 'EditTaskOperation' directly from the client
- Minor checkstyle cleanup and refactoring for Paste handler
- Make CutOperationHandler GModel-specific as it returns recording cmd
- Let LayoutOperationHandler inherit from generic base class
- Update some JavaDoc

Relates to eclipse-glsp/glsp#864
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@tortmayr tortmayr merged commit 6d5bb5a into master Jan 30, 2023
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
eclipse-glsp#191)

- Use 'EditTaskOperation' directly from the client
- Minor checkstyle cleanup and refactoring for Paste handler
- Make CutOperationHandler GModel-specific as it returns recording cmd
- Let LayoutOperationHandler inherit from generic base class
- Update some JavaDoc

Relates to eclipse-glsp/glsp#864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants