Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes eclipse-glsp/glsp#1212 #224

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

ivy-cst
Copy link
Contributor

@ivy-cst ivy-cst commented Jan 24, 2024

Always execute post update queue even if there is no handler for the UpdateModelAction

Always execute post update queue even if there is no handler for the UpdateModelAction
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ivy-cst! Code looks good to me and the semantic change ("post update" even if there is no handler for the "update") is also fine with me. By default the client should register as an UpdateModelAction handler but I agree that we should clear the queue even if that is not the case.

CI fails as we are in the middle of a release so we need to update some other things before merging this.

@ivy-cst
Copy link
Contributor Author

ivy-cst commented Jan 24, 2024

Thank you @ivy-cst! Code looks good to me and the semantic change ("post update" even if there is no handler for the "update") is also fine with me. By default the client should register as an UpdateModelAction handler but I agree that we should clear the queue even if that is not the case.

CI fails as we are in the middle of a release so we need to update some other things before merging this.

May be it is also because we use old clients at the moment which do not provide the clientActionKinds.
But at the moment I do not see where a UpdateModelActionHandler is created or registered?
But looks like I miss something here.

@tortmayr tortmayr merged commit 98530ba into eclipse-glsp:master Jan 24, 2024
5 of 6 checks passed
@ivy-cst
Copy link
Contributor Author

ivy-cst commented Jan 24, 2024

Thanks for the merge before release 👍

MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
Always execute post update queue even if there is no handler for the UpdateModelAction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants