Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements #233

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Minor improvements #233

merged 1 commit into from
Jun 11, 2024

Conversation

tortmayr
Copy link
Contributor

What it does

  • Ensure that the ActionDispatchers postUpdateQueue is also cleared after the inital SetModelAction
  • Change visibility of private members to protected for better extensibility
  • Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr
Minor improvements
bab3fbe 
- Ensure that the ActionDispatchers postUpdateQueue is also cleared after  the inital `SetModelAction`
-  Change visibility of private members to protected for better extensibility
- Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail
planger
planger approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me! 👍

@tortmayr tortmayr merged commit 64a4e3d into master Jun 11, 2024
6 checks passed
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 16, 2024
@tortmayr @MatthiasHofstaetter
Minor improvements (eclipse-glsp#233)
98c3ecb 
- Ensure that the ActionDispatchers postUpdateQueue is also cleared after  the inital `SetModelAction`
-  Change visibility of private members to protected for better extensibility
- Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
@tortmayr
Minor improvements (eclipse-glsp#233)
d1f939b 
- Ensure that the ActionDispatchers postUpdateQueue is also cleared after  the inital `SetModelAction`
-  Change visibility of private members to protected for better extensibility
- Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail
MatthiasHofstaetter pushed a commit to MatthiasHofstaetter/glsp-server that referenced this pull request Dec 21, 2024
@tortmayr @MatthiasHofstaetter
Minor improvements (eclipse-glsp#233)
050c1b0 
- Ensure that the ActionDispatchers postUpdateQueue is also cleared after  the inital `SetModelAction`
-  Change visibility of private members to protected for better extensibility
- Ensuare that Request and Response actions are initialized with an empty string as request/response id. This is required because otherwise typechecks on the client might fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@planger planger planger approved these changes

@martin-fleck-at martin-fleck-at Awaiting requested review from martin-fleck-at

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tortmayr @planger